-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
distrobox-rm: add --image/-i for delete container image #1445
base: main
Are you sure you want to change the base?
Conversation
a89efd4
to
c0a4624
Compare
a96ed21
to
2425c7b
Compare
2425c7b
to
e39964c
Compare
Thanks @Boria138 for the PR! One problem with this is that force-deleting an image will remove also other containers using that image, for example: |
Yes, unfortunately, if you delete the image, then all the containers that use it are also deleted, but I think it's not a problem, because if a person decided to delete the image, I think he does not need the containers as well |
I think you can change that distrobox rm deletes by image name, not by container name. |
e39964c
to
5f77d98
Compare
@89luca89 I rewrote the code so that the image name would be used, but unfortunately --filter only takes one argument at a time |
5f77d98
to
68f9c23
Compare
68f9c23
to
3c2d3ed
Compare
3c2d3ed
to
4e45cf3
Compare
4e45cf3
to
b88991b
Compare
9998c1c
to
a2c3ac5
Compare
@Boria138 tested the code, and from what I see it now is What I would do probably is
This should make it more intuitive to use and less error prone what do you think? |
I like this idea I will soon be implementing it |
a2c3ac5
to
92e571e
Compare
b190c53
to
a6588f9
Compare
a6588f9
to
14f6251
Compare
No description provided.